On Tue, Mar 24, 2015 at 02:27:56PM +0000, Charles Keepax wrote:

> +static int arizona_ldo1_hc_set_voltage_time_sel(struct regulator_dev *rdev,
> +						unsigned int old_selector,
> +						unsigned int new_selector)
> +{
> +	/* if moving to 1.8v allow time for it to reach voltage */
> +	if (new_selector == rdev->desc->n_voltages - 1)
> +		return 25;
> +	else
> +		return 0;
> +}

So changes to move to the top voltage always take constant time while
all other voltage changes are instantaneous?  That doesn't seem right.
I'd expect something more like a calculation based on some number of
miliseconds per milivolt.