From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754432AbbCXQGU (ORCPT ); Tue, 24 Mar 2015 12:06:20 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:59115 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754360AbbCXQGQ (ORCPT ); Tue, 24 Mar 2015 12:06:16 -0400 Date: Tue, 24 Mar 2015 09:06:43 -0700 From: Mark Brown To: Charles Keepax Cc: lee.jones@linaro.org, sameo@linux.intel.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Message-ID: <20150324160642.GE17265@sirena.org.uk> References: <1427209192-12795-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1427209192-12795-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uCPdOCrL+PnN2Vxy" Content-Disposition: inline In-Reply-To: <1427209192-12795-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> X-Cookie: A good memory does not equal pale ink. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 12.104.145.3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/5] mfd: arizona: Add missing gpio_free in arizona_dev_exit X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uCPdOCrL+PnN2Vxy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 24, 2015 at 02:59:48PM +0000, Charles Keepax wrote: > - if (arizona->pdata.reset) > + if (arizona->pdata.reset) { > gpio_set_value_cansleep(arizona->pdata.reset, 0); > + gpio_free(arizona->pdata.reset); > + } Or acquire the GPIO with devm_ and avoid having to explicitly free it at all? --uCPdOCrL+PnN2Vxy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVEYuSAAoJECTWi3JdVIfQ3qoH/30pgvkEL3raieF6k4xj6sNf /9mzZd+GQ/aLn1lztHHJB/05osV+HZINDmxnSwFqH2QENznku7hNTV76hfSfzxLC /1s2cKxVJa8sdqozVzuRpAz3wmm0ZZEK6ya3z3GXZ5kJ2o5mDecctVvp4YjsWpPU dxVQbBBQo8AfUwOixuN3ogm5qNgHCG+Anc3WA2wWsAQiQORJM31vMREDCl6gLlbs 9NmOGQlA981TCdVioQ5irNXjYm3w0ROSrsUax6BqBp0qAGX5fBogvhHlFWplUtrD rtuniP+q66RIFeLpGUQITeTxlvjisn4z24rsziC833WxZtRLhQaBUZSJSTU6/kc= =3XSi -----END PGP SIGNATURE----- --uCPdOCrL+PnN2Vxy--