From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755189AbbCXQbK (ORCPT ); Tue, 24 Mar 2015 12:31:10 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:47222 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbbCXQbD (ORCPT ); Tue, 24 Mar 2015 12:31:03 -0400 Date: Tue, 24 Mar 2015 11:30:08 -0500 From: Felipe Balbi To: Badhri Jagan Sridharan CC: Peter Chen , Felipe Balbi , Greg Kroah-Hartman , , Subject: Re: [PATCH] usb: gadget: Check for NULL pointer in disconnect Message-ID: <20150324163008.GB31024@saruman.tx.rr.com> Reply-To: References: <1426894852-4256-1-git-send-email-Badhri@google.com> <20150322074353.GA25278@shlinux2> <55109B15.9080800@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline In-Reply-To: <55109B15.9080800@google.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 23, 2015 at 04:00:37PM -0700, Badhri Jagan Sridharan wrote: > > Do you really see some udc drivers call it after composite_unbind is > > called? If it is, you may add dump_stack() to track that error. > > > > Besides this, function suspended_show is needed to add cdev NULL pointer > > checking. >=20 > We see this happening occasionally in *not yet* upstreamed UDC > code of some vendors (Yes, disconnect being called after unbind) fix your UDC. We leave these sort of thing open so people realise they have to fix their drivers. --=20 balbi --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVEZEQAAoJEIaOsuA1yqREvb4QAKzU4QyXUZ0v0WQZxSLmb45V 89BrCsGasDzkmA7/IIshFP5uWoGKIIoBWUp0lP/LivAhhTWP9VE9PV0Onlf993jD ulNWBfIZI6wtgRrN1qmmo4iwJLa0fSXwvS9MV4OcE2TcGQxJf0GdmPcoFWPrJzK7 9dhdOlRJJtBik0BhxBNjpTVN5EvxEvhNE47yfa763+OdK8DPUoVUnoEGlH2as7Cn REehpCQvGVeYR7KGt5BmvSxduymmjbusOiVC6zzAwLBg72pQjqPxZMzUsA23N0SJ hKtwKRnlgdEybyDB0MsXjoxE4QUwn8VcPx1o9i5jkcuWeB8QE1HHRq/Xmru5lO36 qp1q0BpKi8GMDrrwd+a4xdo0+KmZUQsWIf/Wf4LfjYgPZJQYxjzdO/FvO7CFWM4q Awr6XPB+Hvg70+ZCx9eX72MKTmFBUbyQH1dnOyWE8iRj3tCy/pC2gACYggi8/H8E G9n+6VPFHEip9+qS7/eVqF6AsQPHi5JSwNLIgrH37foZOQ8HiAkxvLkn2pgh0U7Z 2j5rQ+sw8/U9WloML7voeDhFLDCdNjNxpiPjIKgKtKGxXKeUGI4B7huDMeIUr4qv vMWOIYuyY2peU9xz4RMccc39YgVELJeGjXG6VvywLG3xsjeOBEiHKS/L1h9DxOwZ vcoRDGcMi1H8SbsW4cU9 =nj35 -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--