From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752809AbbCXW0W (ORCPT ); Tue, 24 Mar 2015 18:26:22 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58192 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752381AbbCXWZ5 (ORCPT ); Tue, 24 Mar 2015 18:25:57 -0400 Date: Tue, 24 Mar 2015 23:25:54 +0100 From: David Sterba To: Chengyu Song Cc: clm@fb.com, jbacik@fb.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu Subject: Re: [PATCH 1/1] btrfs: incorrect handling for fiemap_fill_next_extent return Message-ID: <20150324222554.GZ20767@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Chengyu Song , clm@fb.com, jbacik@fb.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu References: <1427235176-19381-1-git-send-email-csong84@gatech.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427235176-19381-1-git-send-email-csong84@gatech.edu> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 06:12:56PM -0400, Chengyu Song wrote: > fiemap_fill_next_extent returns 0 on success, -errno on error, 1 if this was > the last extent that will fit in user array. If 1 is returned, the return > value may eventually returned to user space, which should not happen, according > to manpage of ioctl. > > Signed-off-by: Chengyu Song Good catch, thanks. Reviewed-by: David Sterba Should go to stable.