mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/wmi: delete unused wmi_data_lock mutex causing gcc warning
Date: Wed, 25 Mar 2015 10:26:35 -0700	[thread overview]
Message-ID: <20150325172635.GA19129@fury.dvhart.com> (raw)
In-Reply-To: <1427133697-7228-1-git-send-email-paul.gortmaker@windriver.com>

On Mon, Mar 23, 2015 at 02:01:37PM -0400, Paul Gortmaker wrote:
> In commit bff431e49ff531a343fbb2b4426e313000844f32 ("ACPI: WMI: Add
> ACPI-WMI mapping driver") this mutex was added, but the rest of the
> final commit never actually made use of it, resulting in:
> 
>  In file included from include/linux/mutex.h:29:0,
>                   from include/linux/kernfs.h:13,
>                   from include/linux/sysfs.h:15,
>                   from include/linux/kobject.h:21,
>                   from include/linux/device.h:17,
>                   from drivers/platform/x86/wmi.c:35:
>  drivers/platform/x86/wmi.c:48:21: warning: ‘wmi_data_lock’ defined but not used [-Wunused-variable]
>   static DEFINE_MUTEX(wmi_data_lock);
>                       ^
> 
> A git grep shows no other instances/references to the wmi_data_lock.
> Delete it, assuming that the mutex addition was just a leftover from
> an earlier work in progress version of the change, since the original
> dates from 2008.
> 
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Queued, thank you Paul.

-- 
Darren Hart
Intel Open Source Technology Center

      reply	other threads:[~2015-03-25 17:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 18:01 Paul Gortmaker
2015-03-25 17:26 ` Darren Hart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150325172635.GA19129@fury.dvhart.com \
    --to=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®