From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932536AbbCYQnh (ORCPT ); Wed, 25 Mar 2015 12:43:37 -0400 Received: from down.free-electrons.com ([37.187.137.238]:46060 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932304AbbCYQnc (ORCPT ); Wed, 25 Mar 2015 12:43:32 -0400 Date: Wed, 25 Mar 2015 17:43:21 +0100 From: Thomas Petazzoni To: Yijing Wang Cc: Bjorn Helgaas , Jason Cooper , Jiang Liu , , Yinghai Lu , , Marc Zyngier , , Russell King , , Thomas Gleixner , Benjamin Herrenschmidt , Rusty Russell , Tony Luck , , "David S. Miller" , "Guan Xuetao" , , , Liviu Dudau , "Arnd Bergmann" , Geert Uytterhoeven Subject: Re: [PATCH v8 23/30] PCI/mvebu: Use pci_common_init_dev() to simplify code Message-ID: <20150325174321.4a5bc25d@free-electrons.com> In-Reply-To: <551277E6.1010307@huawei.com> References: <1427168064-8657-1-git-send-email-wangyijing@huawei.com> <1427168064-8657-24-git-send-email-wangyijing@huawei.com> <551277E6.1010307@huawei.com> Organization: Free Electrons X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Yijing Wang, On Wed, 25 Mar 2015 16:55:02 +0800, Yijing Wang wrote: > Do you have any comment for this patch ? In this series, pci_bus_add_devices() > has been ripped out from pci_scan_root_bus(), so I think the pci_scan_root_bus() is > almost the same as pci_create_root_bus + pci_scan_child_bus(). And in this series, > we try to unexport pci_create_root_bus(). It's even better if you could help test this changes. I'm away this week for ELC, but I promise to test you patch series on mvebu hardware next week. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com