From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752836AbbCYTCu (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Mar 2015 15:02:50 -0400
Received: from youngberry.canonical.com ([91.189.89.112]:55992 "EHLO
	youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752309AbbCYTCt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Mar 2015 15:02:49 -0400
Date: Wed, 25 Mar 2015 19:02:41 +0000
From: Luis Henriques <luis.henriques@canonical.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>, Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH] ftracetest: replace usleep by sleep
Message-ID: <20150325190241.GB11923@charon.olymp>
References: <1427304994-1149-1-git-send-email-luis.henriques@canonical.com>
 <20150325145758.6466c7a1@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20150325145758.6466c7a1@gandalf.local.home>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 25, 2015 at 02:57:58PM -0400, Steven Rostedt wrote:
> On Wed, 25 Mar 2015 17:36:34 +0000
> Luis Henriques <luis.henriques@canonical.com> wrote:
> 
> > 'usleep' seems to be a distro-specific utility and may not be
> > available:
> > 
> >  [5] event tracing - enable/disable with event level files       [FAIL]
> >  execute: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> >  + . /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> >  + [ ! -f set_event -o ! -d events/sched ]
> >  + reset_tracer
> >  + echo nop
> >  + do_reset
> >  + echo
> >  + clear_trace
> >  + echo
> >  + echo sched:sched_switch
> >  + usleep 1
> >  ./ftracetest: 24: /home/miguel/linux/tools/testing/selftests/ftrace/test.d/event/event-enable.tc: usleep: not found
> > 
> > Replace it with the more standard sleep.
> > 
> > Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> > ---
> >  tools/testing/selftests/ftrace/test.d/event/event-enable.tc     | 6 +++---
> >  tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 6 +++---
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> > index 668616d9bb03..abafc0c3605c 100644
> > --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> > @@ -21,7 +21,7 @@ reset_tracer
> >  do_reset
> >  
> >  echo 'sched:sched_switch' > set_event
> > -usleep 1
> > +sleep 0.001
> 
> We had patches out about this, because sleep 0.001 is not always
> supported either.
> 
> I forgot what the final solution was suppose to be.
> 
> -- Steve

Would a 'sleep 1' be acceptable?  Do we care about the execution time?

Cheers,
--
Luís