From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chengyu Song <csong84@gatech.edu>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu,
blee@gatech.edu
Subject: Re: [PATCH 1/1] nfsd: NFSD_FAULT_INJECTION depends on DEBUG_FS
Date: Wed, 25 Mar 2015 21:02:43 -0400 [thread overview]
Message-ID: <20150326010243.GB20086@fieldses.org> (raw)
In-Reply-To: <1427315827-6323-1-git-send-email-csong84@gatech.edu>
On Wed, Mar 25, 2015 at 04:37:07PM -0400, Chengyu Song wrote:
> NFSD_FAULT_INJECTION depends on DEBUG_FS, otherwise the debugfs_create_*
> interface may return unexpected error -ENODEV, and cause system crash.
Thanks, applying for 4.1.--b.
>
> Signed-off-by: Chengyu Song <csong84@gatech.edu>
> ---
> fs/nfsd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
> index 683bf71..8b87b7a 100644
> --- a/fs/nfsd/Kconfig
> +++ b/fs/nfsd/Kconfig
> @@ -107,7 +107,7 @@ config NFSD_V4_SECURITY_LABEL
>
> config NFSD_FAULT_INJECTION
> bool "NFS server manual fault injection"
> - depends on NFSD_V4 && DEBUG_KERNEL
> + depends on NFSD_V4 && DEBUG_KERNEL && DEBUG_FS
> help
> This option enables support for manually injecting faults
> into the NFS server. This is intended to be used for
> --
> 2.1.0
prev parent reply other threads:[~2015-03-26 1:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 20:37 Chengyu Song
2015-03-26 1:02 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326010243.GB20086@fieldses.org \
--to=bfields@fieldses.org \
--cc=blee@gatech.edu \
--cc=changwoo@gatech.edu \
--cc=csong84@gatech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=sanidhya@gatech.edu \
--cc=taesoo@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®