From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752281AbbCZIHA (ORCPT ); Thu, 26 Mar 2015 04:07:00 -0400 Received: from verein.lst.de ([213.95.11.211]:51300 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843AbbCZIG6 (ORCPT ); Thu, 26 Mar 2015 04:06:58 -0400 Date: Thu, 26 Mar 2015 09:06:56 +0100 From: Christoph Hellwig To: Ross Zwisler Cc: Christoph Hellwig , linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, boaz@plexistor.com, axboe@kernel.dk Subject: Re: [PATCH 1/3] pmem: Initial version of persistent memory driver Message-ID: <20150326080656.GE26540@lst.de> References: <1427299449-26722-1-git-send-email-hch@lst.de> <1427299449-26722-2-git-send-email-hch@lst.de> <1427314913.14654.1.camel@theros.lm.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427314913.14654.1.camel@theros.lm.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2015 at 02:21:53PM -0600, Ross Zwisler wrote: > What needed to be fixed with the partition support? I used to have real > numbers for first_minor and passed into alloc_disk(), but simplified it based > on code found in this commit in the nvme driver: > > 469071a37afc NVMe: Dynamically allocate partition numbers > > This has worked fine for me - is there some test case in which it breaks? Yes, if CONFIG_DEBUG_BLOCK_EXT_DEVT isn't set that code doesn't work at all. > > +out_unmap: > > + pmem_unmapmem(pmem); > > +out_free_dev: > > + kfree(pmem); > > +out: > > This label is no longer used, and can be removed. Ok, fixed.