From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752971AbbCZNxJ (ORCPT ); Thu, 26 Mar 2015 09:53:09 -0400 Received: from smtprelay0223.hostedemail.com ([216.40.44.223]:34139 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752400AbbCZNxF (ORCPT ); Thu, 26 Mar 2015 09:53:05 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:3872:3873:3874:4321:5007:6261:7514:7875:7901:7903:10004:10400:10848:10967:11026:11232:11658:11914:12296:12438:12517:12519:12740:13069:13161:13229:13311:13357:14093:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: pigs44_8f160910e060b X-Filterd-Recvd-Size: 2794 Date: Thu, 26 Mar 2015 09:53:02 -0400 From: Steven Rostedt To: Mike Galbraith Cc: Thavatchai Makphaibulchoke , linux-kernel@vger.kernel.org, linux-rt-users , Thomas Gleixner , Carsten Emde , Sebastian Andrzej Siewior , John Kacur , Paul Gortmaker Subject: Re: [PATCH RT 2/4] Revert "timers: do not raise softirq unconditionally" Message-ID: <20150326095302.2998cbe4@gandalf.local.home> In-Reply-To: <1427351250.3497.49.camel@gmail.com> References: <20150317163541.080310081@goodmis.org> <20150317163617.218582800@goodmis.org> <20150317163551.3093b6c2@gandalf.local.home> <1426753029.4168.80.camel@gmail.com> <20150319122611.0d002d48@gandalf.local.home> <550AFC6A.4050901@hp.com> <1426960943.4677.34.camel@gmail.com> <1427085774.3151.7.camel@gmail.com> <55136C2A.60508@hp.com> <1427347391.3497.25.camel@gmail.com> <1427351250.3497.49.camel@gmail.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Mar 2015 07:27:30 +0100 Mike Galbraith wrote: > On Thu, 2015-03-26 at 06:23 +0100, Mike Galbraith wrote: > > > I plan on taking a poke at getting "don't raise timer unconditionally" > > working again when I get myself unburied, and see if I can come up with > > a somewhat less icky way to work around take rtmutex in irq naughtiness. > > Hm.. like maybe only do a fasttrylock with the wait lock already held > via trylock, and don't bother turning it loose until we're done, to keep > the sane people away. That might work.. but may not be considered less > icky by people equipped with that mysterious "taste" thingy ;-) You would still need to add some ownership so that all will fail the fast path. You mean create a spin_trylock_in_hirq() which would just lock the waitlock and not even do the fast path with the rt_mutex. if (!raw_spin_trylock(waitlock)) goto failed_lock; if (!try_to_take_rt_mutex()) { raw_spin_unlock(waitlock); goto failed_lock; } return success; With the waitlock held, no slow path will get to the pi code. Then you have a spin_unlock_in_hirq() that would go right into the slow path assuming the waitlock is already held. Sounds reasonable to me. -- Steve