From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279AbbCZSQ2 (ORCPT ); Thu, 26 Mar 2015 14:16:28 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40359 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbbCZSQ0 (ORCPT ); Thu, 26 Mar 2015 14:16:26 -0400 Date: Thu, 26 Mar 2015 11:16:20 -0700 From: Mark Brown To: Yakir Yang Cc: Liam Girdwood , djkurtz@chromium.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, David Airlie , Philipp Zabel , Russell King , Andy Yan , Greg Kroah-Hartman , Fabio Estevam , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , Brian Austin , Bard Liao , Oder Chiou , Max Filippov , Axel Lin , Arnd Bergmann , Jyri Sarha , Sean Cross , Ben Zhang , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, mmind00@googlemail.com, marcheu@chromium.org, mark.yao@rock-chips.com Message-ID: <20150326181620.GZ3572@sirena.org.uk> References: <1425175834-24661-1-git-send-email-ykk@rock-chips.com> <1425179070-2736-1-git-send-email-ykk@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NJ3GtppTlf/130kA" Content-Disposition: inline In-Reply-To: <1425179070-2736-1-git-send-email-ykk@rock-chips.com> X-Cookie: Better dead than mellow. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 12.51.221.141 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 14/15] ASoC: rockchip/rockchip-hdmi-audio: add sound driver for hdmi audio X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NJ3GtppTlf/130kA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Feb 28, 2015 at 10:04:30PM -0500, Yakir Yang wrote: > + ret = snd_soc_dai_set_fmt(cpu_dai, dai_fmt); > + if (ret < 0) { > + dev_err(cpu_dai->dev, "failed to set cpu_dai fmt.\n"); > + return ret; > + } You've already set this in the dai_link, no need to do it again. > + dev_info(&pdev->dev, "hdmi audio init success.\n"); Please remove noisy prints like this. > +free_cpu_of_node: > + hdmi_audio_dai.cpu_of_node = NULL; > + hdmi_audio_dai.platform_of_node = NULL; > +free_priv_data: > + snd_soc_card_set_drvdata(card, NULL); > + platform_set_drvdata(pdev, NULL); > + card->dev = NULL; If any of these assignments is doing anything there's a problem with the code. > +{ > + struct snd_soc_card *card = platform_get_drvdata(pdev); > + > + snd_soc_unregister_card(card); devm_snd_soc_register_card() and you can remove this function entirely. > +static const struct of_device_id rockchip_hdmi_audio_of_match[] = { > + { .compatible = "rockchip,rk3288-hdmi-audio", }, > + {}, > +}; There is no documentation for this binding, binding documentation is mandatory. Based on the compatible string this looks like it's specific to the SoC rather than a design for a board - is the whole card part of the SoC? --NJ3GtppTlf/130kA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVFEzzAAoJECTWi3JdVIfQDHoH/1e/8agSVnWGgaEMc0obh/dg 6AHcHMbXlJJ+df8MK4p/pIdgkq8an4KWXmSHY/tbQ0Z8ylVEImUq5eZi42ZU+P/v PWPLwkYoant5d+QryNF61Gze0PkImIWvbI7pzEAhrXUVfyi9VAXazxTpDotCHWGl G2A6CBMDTgRUEuz4/yIDpBxTxEm0E7ymg5OQvad1eKJvMlIdoaKoLryOeJ+tIQ7q 8D20Kj2gHJDgFT+SFLmD//XgLpnFTO3ELHdrJq8k4bMzlPVxkkPpTjTG0tvfxAOd e4j3dDI0tDTd1IGrCeQoCLQ964wMGKiUNcvELk4DNLPPZ/MYqd+72/jFKF6z2bQ= =ipGX -----END PGP SIGNATURE----- --NJ3GtppTlf/130kA--