mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Bandan Das <bsd@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/apic: remove read/write test in verify_local_apic()
Date: Fri, 27 Mar 2015 13:10:58 +0100	[thread overview]
Message-ID: <20150327121058.GA15631@gmail.com> (raw)
In-Reply-To: <jpgtwxiuj99.fsf@redhat.com>


* Bandan Das <bsd@redhat.com> wrote:

> 
> Most newer processors have the APIC_ID read-only and this
> test probably fails on most boxes anyway. Fix typos.
> 
> Signed-off-by: Bandan Das <bsd@redhat.com>
> ---
> Honestly, I don't think this function is really needed.
> It's called for both UP/MP but the return value isn't
> used by any of them. Maybe, we should just remove it ?

Agreed, lets just remove it.

Thanks,

	Ingo

      reply	other threads:[~2015-03-27 12:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 20:45 Bandan Das
2015-03-27 12:10 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150327121058.GA15631@gmail.com \
    --to=mingo@kernel.org \
    --cc=bsd@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome