From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753073AbbC0WQN (ORCPT ); Fri, 27 Mar 2015 18:16:13 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49514 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbbC0WQL (ORCPT ); Fri, 27 Mar 2015 18:16:11 -0400 Date: Fri, 27 Mar 2015 15:16:10 -0700 From: Andrew Morton To: Joe Perches Cc: Mark Fasheh , Joel Becker , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH 2/2] ocfs2: Neaten do_error, ocfs2_error and ocfs2_abort Message-Id: <20150327151610.bcc26d7577d35ce636d21833@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Mar 2015 20:07:08 -0700 Joe Perches wrote: > These uses sometimes do and sometimes don't have '\n' terminations. > Make the uses consistently use '\n' terminations and remove the > newline from the functions. This is going to take a while to merge, as it's backed up behind a pile of needs-more-reviewing ocfs2 patches. Namely: #ocfs2-trusted-xattr-missing-cap_sys_admin-check.patch: breaks userspace? ocfs2-trusted-xattr-missing-cap_sys_admin-check.patch # ocfs2-flush-inode-data-to-disk-and-free-inode-when-i_count-becomes-zero.patch # add-errors=continue.patch acknowledge-return-value-of-ocfs2_error.patch clear-the-rest-of-the-buffers-on-error.patch # ocfs2-fix-a-tiny-case-that-inode-can-not-removed.patch # #ocfs2-use-64bit-variables-to-track-heartbeat-time.patch: acks? ocfs2-use-64bit-variables-to-track-heartbeat-time.patch # #ocfs2-call-ocfs2_journal_access_di-before-ocfs2_journal_dirty-in-ocfs2_write_end_nolock.patch: acks? Mark wants changes. Mark has list of notes ocfs2-call-ocfs2_journal_access_di-before-ocfs2_journal_dirty-in-ocfs2_write_end_nolock.patch # #ocfs2-avoid-access-invalid-address-when-read-o2dlm-debug-messages.patch: acks? Mark has issues ocfs2-avoid-access-invalid-address-when-read-o2dlm-debug-messages.patch ocfs2-avoid-access-invalid-address-when-read-o2dlm-debug-messages-v3.patch