From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752261AbbC1QUB (ORCPT ); Sat, 28 Mar 2015 12:20:01 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.229]:36361 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750855AbbC1QUA (ORCPT ); Sat, 28 Mar 2015 12:20:00 -0400 Date: Sat, 28 Mar 2015 12:20:39 -0400 From: Steven Rostedt To: Xie XiuQi Cc: , Ingo Molnar , Andrew Morton , Namhyung Kim , Masami Hiramatsu , Mathieu Desnoyers , Mauro Carvalho Chehab Subject: Re: [RFC][PATCH 09/10] v4l: Export enums used by tracepoints to user space Message-ID: <20150328122039.35b94a41@grimm.local.home> In-Reply-To: <5516A5ED.4050108@huawei.com> References: <20150327213704.857765144@goodmis.org> <20150327213814.576750758@goodmis.org> <5516A5ED.4050108@huawei.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 28 Mar 2015 21:00:29 +0800 Xie XiuQi wrote: > On 2015/3/28 5:37, Steven Rostedt wrote: > > > #define show_field(field) \ > > - __print_symbolic(field, \ > > - { V4L2_FIELD_ANY, "ANY" }, \ > > - { V4L2_FIELD_NONE, "NONE" }, \ > > - { V4L2_FIELD_TOP, "TOP" }, \ > > - { V4L2_FIELD_BOTTOM, "BOTTOM" }, \ > > - { V4L2_FIELD_INTERLACED, "INTERLACED" }, \ > > - { V4L2_FIELD_SEQ_TB, "SEQ_TB" }, \ > > - { V4L2_FIELD_SEQ_BT, "SEQ_BT" }, \ > > - { V4L2_FIELD_ALTERNATE, "ALTERNATE" }, \ > > - { V4L2_FIELD_INTERLACED_TB, "INTERLACED_TB" }, \ > > - { V4L2_FIELD_INTERLACED_BT, "INTERLACED_BT" }) > > + __print_symbolic(field, SHOW_FIELD > > Hi Steve, > > It is missing a right bracket ')' here. > Yep, I haven't run these through my full test suite yet. I only did some basic tests (and haven't compiled all the modules yet). Wu's autobot picked up this error. -- Steve