From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753222AbbC3Iy5 (ORCPT ); Mon, 30 Mar 2015 04:54:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53766 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbbC3Iyz (ORCPT ); Mon, 30 Mar 2015 04:54:55 -0400 Date: Mon, 30 Mar 2015 10:54:34 +0200 From: Jiri Olsa To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com, acme@kernel.org, acme@redhat.com, jolsa@kernel.org, kan.liang@intel.com, namhyung@kernel.org, adrian.hunter@intel.com, ak@linux.intel.com, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com Subject: Re: [PATCH v2] perf callchain: fix kernel symbol resolution by remembering the cpumode Message-ID: <20150330085434.GA12734@krava.brq.redhat.com> References: <1427468906-41544-1-git-send-email-dahi@linux.vnet.ibm.com> <1427703060-59883-1-git-send-email-dahi@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427703060-59883-1-git-send-email-dahi@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2015 at 10:11:00AM +0200, David Hildenbrand wrote: > Commit 2e77784bb7d8 ("perf callchain: Move cpumode resolve code to > add_callchain_ip") promised "No change in behavior.". > > As this commit breaks callchains on s390x (symbols not getting resolved, I think it's a generic problem not just s390x the x86 archs were safe due to the (al->map == NULL) fallback in thread__find_addr_map, where we rerun the lookup for kernel maps.. I need to rethink this check :-\ perhaps s390x did not match the machine__kernel_ip condition? > observed when profiling the kernel), this statement is wrong. The cpumode > must be kept when iterating over all ips, otherwise the default > (PERF_RECORD_MISC_USER) will be used by error. anyway Acked-by: Jiri Olsa thanks, jirka