From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753022AbbC3JSc (ORCPT ); Mon, 30 Mar 2015 05:18:32 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:42098 "EHLO e06smtp14.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbbC3JSa (ORCPT ); Mon, 30 Mar 2015 05:18:30 -0400 Date: Mon, 30 Mar 2015 11:18:19 +0200 From: David Hildenbrand To: Jiri Olsa Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com, acme@kernel.org, acme@redhat.com, jolsa@kernel.org, kan.liang@intel.com, namhyung@kernel.org, adrian.hunter@intel.com, ak@linux.intel.com, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com Subject: Re: [PATCH v2] perf callchain: fix kernel symbol resolution by remembering the cpumode Message-ID: <20150330111819.0193c04e@thinkpad-w530> In-Reply-To: <20150330085434.GA12734@krava.brq.redhat.com> References: <1427468906-41544-1-git-send-email-dahi@linux.vnet.ibm.com> <1427703060-59883-1-git-send-email-dahi@linux.vnet.ibm.com> <20150330085434.GA12734@krava.brq.redhat.com> Organization: IBM Deutschland GmbH X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15033009-0017-0000-0000-0000038B0122 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Mon, Mar 30, 2015 at 10:11:00AM +0200, David Hildenbrand wrote: > > Commit 2e77784bb7d8 ("perf callchain: Move cpumode resolve code to > > add_callchain_ip") promised "No change in behavior.". > > > > As this commit breaks callchains on s390x (symbols not getting resolved, > > I think it's a generic problem not just s390x > > the x86 archs were safe due to the (al->map == NULL) fallback > in thread__find_addr_map, where we rerun the lookup for kernel > maps.. I need to rethink this check :-\ > > perhaps s390x did not match the machine__kernel_ip condition? Most probably yes, in contrast to other archs, we can't really decide based on the address if it belongs to user or kernel space. So we need the context. > > > > observed when profiling the kernel), this statement is wrong. The cpumode > > must be kept when iterating over all ips, otherwise the default > > (PERF_RECORD_MISC_USER) will be used by error. > > anyway > > Acked-by: Jiri Olsa > > Thanks! David