From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753526AbbC3Tuz (ORCPT ); Mon, 30 Mar 2015 15:50:55 -0400 Received: from smtprelay0083.hostedemail.com ([216.40.44.83]:36078 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753021AbbC3Tux (ORCPT ); Mon, 30 Mar 2015 15:50:53 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2899:3138:3139:3140:3141:3142:3352:3622:3653:3868:3871:3874:4250:4605:5007:6261:7875:10004:10400:10848:10967:11232:11658:11914:12043:12517:12519:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: lace32_78ab76b86a44 X-Filterd-Recvd-Size: 1941 Date: Mon, 30 Mar 2015 15:50:50 -0400 From: Steven Rostedt To: Michael Ellerman Cc: shuahkh@osg.samsung.com, , davej@codemonkey.org.uk, namhyung@kernel.org Subject: Re: [PATCH v2] ftracetest: Convert exit -1 to exit $FAIL Message-ID: <20150330155050.4715e9fb@gandalf.local.home> In-Reply-To: <1427692860-6423-1-git-send-email-mpe@ellerman.id.au> References: <1427692860-6423-1-git-send-email-mpe@ellerman.id.au> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Mar 2015 16:21:00 +1100 Michael Ellerman wrote: > POSIX says that exit takes an unsigned integer between 0 and 255, so > using -1 doesn't work on POSIX shells. > > There is already a well-defined failure code, $FAIL (1), so use that. > > Signed-off-by: Michael Ellerman Acked-by: Steven Rostedt -- Steve > --- > > v2: Use exit $FAIL not exit 255. > > tools/testing/selftests/ftrace/test.d/00basic/basic4.tc | 2 +- > tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 2 +- > tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 2 +- > tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc | 2 +- > tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc | 2 +- > tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc | 2 +- > tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc | 2 +- > 7 files changed, 7 insertions(+), 7 deletions(-) >