From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753067AbbC3Vgg (ORCPT ); Mon, 30 Mar 2015 17:36:36 -0400 Received: from smtprelay0200.hostedemail.com ([216.40.44.200]:57843 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751197AbbC3Vgf (ORCPT ); Mon, 30 Mar 2015 17:36:35 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3871:3872:4401:5007:6261:7875:7903:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12438:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: wall04_395b68467d328 X-Filterd-Recvd-Size: 1698 Date: Mon, 30 Mar 2015 17:36:33 -0400 From: Steven Rostedt To: Michael Ellerman Cc: shuahkh@osg.samsung.com, , davej@codemonkey.org.uk, namhyung@kernel.org Subject: Re: [PATCH] ftracetest: Cope properly with stack tracer not being enabled Message-ID: <20150330173633.64c53cb9@gandalf.local.home> In-Reply-To: <1427692900-11191-1-git-send-email-mpe@ellerman.id.au> References: <1427692900-11191-1-git-send-email-mpe@ellerman.id.au> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Mar 2015 16:21:40 +1100 Michael Ellerman wrote: > If the stack tracer (CONFIG_STACK_TRACER) is disabled, the > fgraph-filter-stack test blows chunks: > > [8] ftrace - function graph filters with stack tracer [FAIL] > + reset_tracer > + echo nop > ./ftracetest: 19: /home/michael/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc: > cannot create /proc/sys/kernel/stack_tracer_enabled: Directory nonexistent > > Fix it by checking if the proc file exists before echoing to it. With > the patch applied it fails correctly with: > > [8] ftrace - function graph filters with stack tracer [UNSUPPORTED] > > Signed-off-by: Michael Ellerman > --- Acked-by: Steven Rostedt -- Steve