From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753492AbbC3V3v (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Mar 2015 17:29:51 -0400
Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.229]:12064 "EHLO
	cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1753276AbbC3V3u (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Mar 2015 17:29:50 -0400
Date: Mon, 30 Mar 2015 17:29:36 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
        dave.hansen@linux.intel.com
Subject: Re: [PATCH 06/17] x86, mpx: trace attempts to find bounds tables
Message-ID: <20150330212936.GK3042@home.goodmis.org>
References: <20150327215253.8583D538@viggo.jf.intel.com>
 <20150327215303.AB02EF6C@viggo.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150327215303.AB02EF6C@viggo.jf.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-RR-Connecting-IP: 107.14.168.130:25
X-Cloudmark-Score: 0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 27, 2015 at 02:53:03PM -0700, Dave Hansen wrote:
>  b/arch/x86/include/asm/trace/mpx.h |   22 ++++++++++++++++++++++
>  b/arch/x86/mm/mpx.c                |    1 +
>  2 files changed, 23 insertions(+)
> 
> diff -puN arch/x86/include/asm/trace/mpx.h~mpx-trace_unmap_search arch/x86/include/asm/trace/mpx.h
> --- a/arch/x86/include/asm/trace/mpx.h~mpx-trace_unmap_search	2015-03-27 14:35:05.987816914 -0700
> +++ b/arch/x86/include/asm/trace/mpx.h	2015-03-27 14:35:05.992817139 -0700
> @@ -75,6 +75,28 @@ TRACE_EVENT(mpx_unmap_zap,
>  	)
>  );
>  
> +TRACE_EVENT(mpx_unmap_search,
> +
> +	TP_PROTO(unsigned long start,
> +		 unsigned long end),
> +	TP_ARGS(start, end),
> +
> +	TP_STRUCT__entry(
> +		__field(unsigned long, start)
> +		__field(unsigned long, end)
> +	),
> +
> +	TP_fast_assign(
> +		__entry->start = start;
> +		__entry->end   = end;
> +	),
> +
> +	TP_printk("[0x%p:0x%p]",
> +		(void *)__entry->start,
> +		(void *)__entry->end
> +	)
> +);

This event is exactly the same as the previous event. Can you use

DECLARE_EVENT_CLASS() and DEFINE_EVENT() instead?

-- Steve

> +
>  #else
>  
>  /*
> diff -puN arch/x86/mm/mpx.c~mpx-trace_unmap_search arch/x86/mm/mpx.c