From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net
Subject: Re: [PATCH 5/5 linux-next] tpm_ibmvtpm: remove unneccessary message level.
Date: Mon, 30 Mar 2015 22:42:26 +0200 [thread overview]
Message-ID: <201503302242.45888.PeterHuewe@gmx.de> (raw)
In-Reply-To: <1427745969-12959-5-git-send-email-fabf@skynet.be>
Am Montag, 30. März 2015, 22:06:08 schrieb Fabian Frederick:
> KERN_ERR is implicitely declared in pr_err()
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Good catch.
Acked-by: Peter Huewe <peterhuewe@gmx.de>
If nobody else pulls this one through his tree, I'll apply it probably for
4._2_ (so it might take a while)
Peter
> ---
> drivers/char/tpm/tpm_of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
> index c002d1b..eebe625 100644
> --- a/drivers/char/tpm/tpm_of.c
> +++ b/drivers/char/tpm/tpm_of.c
> @@ -49,7 +49,7 @@ int read_log(struct tpm_bios_log *log)
>
> basep = of_get_property(np, "linux,sml-base", NULL);
> if (basep == NULL) {
> - pr_err(KERN_ERR "%s: ERROR - SML not found\n", __func__);
> + pr_err("%s: ERROR - SML not found\n", __func__);
> goto cleanup_eio;
> }
prev parent reply other threads:[~2015-03-30 20:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 20:06 [PATCH 1/5 linux-next] IB/mlx5: " Fabian Frederick
2015-03-30 20:06 ` [PATCH 2/5 linux-next] iw_cxgb4: " Fabian Frederick
2015-03-30 20:17 ` Steve Wise
2015-03-30 20:06 ` [PATCH 3/5 linux-next] IB/mlx4: " Fabian Frederick
2015-03-30 20:06 ` [PATCH 4/5 linux-next] fotg210-hcd: " Fabian Frederick
2015-03-30 20:06 ` [PATCH 5/5 linux-next] tpm_ibmvtpm: " Fabian Frederick
2015-03-30 20:42 ` Peter Hüwe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201503302242.45888.PeterHuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=fabf@skynet.be \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome