From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbbCaPGk (ORCPT ); Tue, 31 Mar 2015 11:06:40 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47602 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbbCaPGi (ORCPT ); Tue, 31 Mar 2015 11:06:38 -0400 Date: Tue, 31 Mar 2015 11:06:36 -0400 (EDT) Message-Id: <20150331.110636.1386273674508393491.davem@davemloft.net> To: yinghai@kernel.org Cc: david.ahern@oracle.com, bhelgaas@google.com, linux-pci@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: d63e2e1f3df breaks sparc/T5-8 From: David Miller In-Reply-To: References: <5519D40D.20903@oracle.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 31 Mar 2015 08:06:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yinghai Lu Date: Mon, 30 Mar 2015 18:06:02 -0700 > ok, that is really non-pref mmio 64bit. > We can workaround the problem by honoring firmware setting, according > to https://www.pcisig.com/specifications/pciexpress/base2/PCIe_Base_r2.1_Errata_08Jun10.pdf > page 13 > > Please check attached updated patches that should fix the regression > and kill those "no compatible window" warnings. Your patch only allows the condition behind resources that have 64-bits of significance, but that is not what the document above says about when this situation is allowed. Please implement the check either exactly as stated in the errata document, or more loosely if that is not possible, rather than more strictly than allowed. Your overly strict and restrictive checks are what got us into this predicament in the first place. :-(