From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979AbbCaRuJ (ORCPT ); Tue, 31 Mar 2015 13:50:09 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:48969 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbbCaRuH (ORCPT ); Tue, 31 Mar 2015 13:50:07 -0400 Date: Tue, 31 Mar 2015 13:50:05 -0400 (EDT) Message-Id: <20150331.135005.914314420842054696.davem@davemloft.net> To: anton@swortex.com Cc: j.vosburgh@gmail.com, vfalico@gmail.com, gospo@cumulusnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexey@swortex.com Subject: Re: [PATCH] Bonding Overriding Configuration logic restored. From: David Miller In-Reply-To: <1427628025-9752-1-git-send-email-anton@swortex.com> References: <1427628025-9752-1-git-send-email-anton@swortex.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 31 Mar 2015 10:50:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anton Nayshtut Date: Sun, 29 Mar 2015 14:20:25 +0300 > Before commit 3900f29021f0bc7fe9815aa32f1a993b7dfdd402 ("bonding: slight > optimizztion for bond_slave_override()") the override logic was to send packets > with non-zero queue_id through the slave with corresponding queue_id, under two > conditions only - if the slave can transmit and it's up. > > The above mentioned commit changed this logic by introducing an additional > condition - whether the bond is active (indirectly, using the slave_can_tx and > later - bond_is_active_slave), that prevents the user from implementing more > complex policies according to the Documentation/networking/bonding.txt. > > Signed-off-by: Anton Nayshtut > Signed-off-by: Alexey Bogoslavsky Applied and queued up for -stable, thanks.