From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753163AbbCaH2z (ORCPT ); Tue, 31 Mar 2015 03:28:55 -0400 Received: from casper.infradead.org ([85.118.1.10]:41307 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbbCaH2y (ORCPT ); Tue, 31 Mar 2015 03:28:54 -0400 Date: Tue, 31 Mar 2015 09:28:55 +0200 From: Peter Zijlstra To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, acme@redhat.com, mingo@elte.hu, ak@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, cel@us.ibm.com, sukadev@linux.vnet.ibm.com, sonnyrao@chromium.org, johnmccutchan@google.com, dsahern@gmail.com, adrian.hunter@intel.com, pawel.moll@arm.com Subject: Re: [PATCH v6 1/4] perf,record: Add clockid parameter Message-ID: <20150331072855.GB12676@worktop.ger.corp.intel.com> References: <1427753974-13380-1-git-send-email-eranian@google.com> <1427753974-13380-2-git-send-email-eranian@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427753974-13380-2-git-send-email-eranian@google.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2015 at 12:19:31AM +0200, Stephane Eranian wrote: > @@ -1044,6 +1051,8 @@ static size_t perf_event_attr__fprintf(struct perf_event_attr *attr, FILE *fp) > ret += PRINT_ATTR2(exclude_host, exclude_guest); > ret += PRINT_ATTR2N("excl.callchain_kern", exclude_callchain_kernel, > "excl.callchain_user", exclude_callchain_user); > + ret += __PRINT_ATTR("%u",,use_clockid); > + > > ret += PRINT_ATTR_U32(wakeup_events); > ret += PRINT_ATTR_U32(wakeup_watermark); > @@ -1056,6 +1065,7 @@ static size_t perf_event_attr__fprintf(struct perf_event_attr *attr, FILE *fp) > ret += PRINT_ATTR_X64(sample_regs_user); > ret += PRINT_ATTR_U32(sample_stack_user); > ret += PRINT_ATTR_X64(sample_regs_intr); > + ret += PRINT_ATTR_U32(clockid); > > ret += fprintf(fp, "%.60s\n", graph_dotted_line); > You also misplaced a bunch of changes here.