From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240AbbCaIq2 (ORCPT ); Tue, 31 Mar 2015 04:46:28 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:60223 "EHLO e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752512AbbCaIqY (ORCPT ); Tue, 31 Mar 2015 04:46:24 -0400 Date: Tue, 31 Mar 2015 10:46:18 +0200 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 0/6] virtio_balloon: virtio 1 support Message-ID: <20150331104618.3da249e3.cornelia.huck@de.ibm.com> In-Reply-To: <1427737006-23191-1-git-send-email-mst@redhat.com> References: <1427737006-23191-1-git-send-email-mst@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15033108-0021-0000-0000-0000036A52B2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Mar 2015 19:37:08 +0200 "Michael S. Tsirkin" wrote: > Virtio 1.0 doesn't include a modern balloon device. > At some point we'll likely define an incompatible interface with a different > ID. But for now, it's not a big change to support a transitional balloon > device: this has the advantage of supporting existing drivers, transparently. This is needed to support a ballooner on transports that don't support mixing legacy and 1.0, right? > > The only issue is with the stats buffer, which has misaligned fields. > Seems easy to fix by prepending a 6 byte reserved field. I assume you also define the stats fields to be le for 1.0? > > I'll post spec patch and qemu patches shortly. I'll defer review until then. > > Michael S. Tsirkin (6): > virtio_balloon: transitional interface > virtio: balloon might not be a legacy device > virtio_ccw: support non-legacy balloon devices > virtio_mmio: support non-legacy balloon devices > virtio_pci: support non-legacy balloon devices > virtio: drop virtio_device_is_legacy_only > > include/linux/virtio.h | 2 -- > include/uapi/linux/virtio_balloon.h | 6 ++++++ > drivers/s390/kvm/virtio_ccw.c | 10 +++------- > drivers/virtio/virtio.c | 6 ------ > drivers/virtio/virtio_balloon.c | 8 ++++++-- > drivers/virtio/virtio_mmio.c | 8 -------- > drivers/virtio/virtio_pci_modern.c | 3 --- > 7 files changed, 15 insertions(+), 28 deletions(-) >