mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
	Don Zickus <dzickus@redhat.com>, Joe Mario <jmario@redhat.com>
Subject: Re: [PATCH v2 1/2] perf tool: Refactor comm/tgid lookup
Date: Tue, 31 Mar 2015 16:35:46 +0200	[thread overview]
Message-ID: <20150331143546.GD31798@krava.brq.redhat.com> (raw)
In-Reply-To: <1427747758-18510-1-git-send-email-dsahern@gmail.com>

On Mon, Mar 30, 2015 at 02:35:57PM -0600, David Ahern wrote:
> Rather than parsing /proc/pid/status file one line at a time, read
> it into a buffer in one shot and search for all strings in one pass.
> 
> tgid conversion also simplified -- removing the isspace walk. As
> noted by Arnaldo those are not needed for atoi == strtol calls.
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>
> Cc: Don Zickus <dzickus@redhat.com>
> Cc: Joe Mario <jmario@redhat.com>
> Cc: Jiri Olsa <jolsa@redhat.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

  parent reply	other threads:[~2015-03-31 14:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 20:35 David Ahern
2015-03-30 20:35 ` [PATCH v3 2/2] perf tool: Fix ppid for synthesized fork events David Ahern
2015-03-31 14:10   ` Jiri Olsa
2015-03-31 14:17     ` Jiri Olsa
2015-03-31 14:35   ` Jiri Olsa
2015-03-31 16:23   ` Don Zickus
2015-04-02 12:23   ` [tip:perf/core] perf tools: " tip-bot for David Ahern
2015-03-31 14:35 ` Jiri Olsa [this message]
2015-03-31 15:55   ` [PATCH v2 1/2] perf tool: Refactor comm/tgid lookup Arnaldo Carvalho de Melo
2015-03-31 16:22 ` Don Zickus
2015-04-02 12:23 ` [tip:perf/core] perf tools: " tip-bot for David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150331143546.GD31798@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=dzickus@redhat.com \
    --cc=jmario@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome