From: Andrew Morton <akpm@linux-foundation.org>
To: Eddie Huang <eddie.huang@mediatek.com>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
srv_heupstream@mediatek.com,
"Samuel Ortiz" <sameo@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
"Joe Perches" <joe@perches.com>, "Tejun Heo" <tj@kernel.org>,
"Jingoo Han" <jg1.han@samsung.com>,
lkml <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
"Uwe Kleine-König" <kernel@pengutronix.de>,
"Tianping Fang" <tianping.fang@mediatek.com>
Subject: Re: [PATCH v2 2/3] rtc: mediatek: Add MT6397 RTC driver
Date: Tue, 31 Mar 2015 15:01:03 -0700 [thread overview]
Message-ID: <20150331150103.c586821d4fddede12551c9ef@linux-foundation.org> (raw)
In-Reply-To: <1427703350.26464.15.camel@mtksdaap41>
On Mon, 30 Mar 2015 16:15:50 +0800 Eddie Huang <eddie.huang@mediatek.com> wrote:
> > > +out_rtc:
> > > + rtc_device_unregister(rtc->rtc_dev);
> >
> > This is wrong. Whenever you jump to this label the RTC device has not
> > been registered yet.
>
> Oops, will fix in next round.
Please ensure that Uwe's review comments (starting at
https://lkml.org/lkml/2015/3/17/494) have been addressed.
next prev parent reply other threads:[~2015-03-31 22:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 5:45 [PATCH v2 0/3] Add Mediatek SoC " Eddie Huang
2015-03-18 5:45 ` [PATCH v2 1/3] mfd: provide RTC resource in MT6397 MFD Eddie Huang
2015-03-18 7:30 ` Lee Jones
2015-03-30 8:17 ` Eddie Huang
2015-03-18 5:45 ` [PATCH v2 2/3] rtc: mediatek: Add MT6397 RTC driver Eddie Huang
2015-03-21 5:25 ` Dmitry Torokhov
2015-03-30 8:15 ` Eddie Huang
2015-03-31 22:01 ` Andrew Morton [this message]
2015-03-30 7:41 ` Tomasz Figa
2015-03-31 9:44 ` Eddie Huang
2015-03-31 11:01 ` Tomasz Figa
2015-03-18 5:45 ` [PATCH v2 3/3] MAINTAINERS: add Mediatek " Eddie Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331150103.c586821d4fddede12551c9ef@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=eddie.huang@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@osg.samsung.com \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=srv_heupstream@mediatek.com \
--cc=tianping.fang@mediatek.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®