From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753640AbbCaNCN (ORCPT ); Tue, 31 Mar 2015 09:02:13 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:40816 "EHLO e06smtp11.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753063AbbCaNCJ (ORCPT ); Tue, 31 Mar 2015 09:02:09 -0400 Date: Tue, 31 Mar 2015 15:02:01 +0200 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] virtio: drop a useless config read Message-ID: <20150331150201.34cb8823.cornelia.huck@de.ibm.com> In-Reply-To: <1427802906-7743-1-git-send-email-mst@redhat.com> References: <1427802906-7743-1-git-send-email-mst@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15033113-0041-0000-0000-000003E92703 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Mar 2015 13:55:42 +0200 "Michael S. Tsirkin" wrote: > commit d71de9ec6ba806104439d3a669befda84757b5af > "virtio: core support for config generation" > fixed reading up 64 bit values, adding generation > checks for such reads. > > By mistake, it left an explicit get call in place > as well. the result is that the value is read twice, > the first result is discarded. > > Not a big deal since this only happens with virtio > blk and only on boot ATM, so performance isn't > affected, but let's clean it up. > > Signed-off-by: Michael S. Tsirkin > --- > include/linux/virtio_config.h | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Cornelia Huck