From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754243AbbCaPHq (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 Mar 2015 11:07:46 -0400
Received: from casper.infradead.org ([85.118.1.10]:44586 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751178AbbCaPHl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 Mar 2015 11:07:41 -0400
Date: Tue, 31 Mar 2015 17:07:30 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>, maninder1.s@samsung.com,
        tglx@linutronix.de, Yogesh Narayan Gaur <yn.gaur@samsung.com>,
        AJEET YADAV <ajeet.y@samsung.com>, Tejun Heo <tj@kernel.org>
Subject: Re: restart_syscall: use freezable blocking call
Message-ID: <20150331150730.GJ23123@twins.programming.kicks-ass.net>
References: <380509604.92081427713655432.JavaMail.weblogic@epmlwas01c>
 <20150330154351.2582ba70df824c6ccc55fb28@linux-foundation.org>
 <1982905.Ac4fTCSUaY@vostro.rjw.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1982905.Ac4fTCSUaY@vostro.rjw.lan>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 31, 2015 at 01:39:07AM +0200, Rafael J. Wysocki wrote:
> > From: Maninder Singh <maninder1.s@samsung.com>
> > Subject: kernel/time/hrtimer.c: restart_syscall: use freezable blocking call
> > 
> > Avoid waking up every thread sleeping in a restart_syscall call during
> > suspend and resume by calling a freezable blocking call.  Previous patches
> > modified the freezer to avoid sending wakeups to threads that are blocked
> > in freezable blocking calls.

This is what, no why mentioned.

> > 
> > Signed-off-by: Yogesh Gaur <yn.gaur <at> samsung.com>
> > Signed-off-by: Amit Arora <amit.arora <at> samsung.com>

This SoB chain is garbage. Most important, note that the author (From by
lack of Author) didn't actually sign off on it.

> > Reviewed-by : Ajeet Yadav <ajeet.y <at> samsung.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> > 
> >  kernel/time/hrtimer.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff -puN kernel/time/hrtimer.c~restart_syscall-use-freezable-blocking-call kernel/time/hrtimer.c
> > --- a/kernel/time/hrtimer.c~restart_syscall-use-freezable-blocking-call
> > +++ a/kernel/time/hrtimer.c
> > @@ -1767,7 +1767,7 @@ schedule_hrtimeout_range_clock(ktime_t *
> >  	 * A NULL parameter means "infinite"
> >  	 */
> >  	if (!expires) {
> > -		schedule();
> > +		freezable_schedule();
> >  		return -EINTR;
> >  	}
> >  
> > @@ -1781,7 +1781,7 @@ schedule_hrtimeout_range_clock(ktime_t *
> >  		t.task = NULL;
> >  
> >  	if (likely(t.task))
> > -		schedule();
> > +		freezable_schedule();
> >  
> >  	hrtimer_cancel(&t.timer);
> >  	destroy_hrtimer_on_stack(&t.timer);

Not a single word on why this would be correct. At the very least show
us you've thought about it.