From: "Dhere, Chaitanya (C.)" <cvijaydh@visteon.com>
To: "oleg.drokin@intel.com" <oleg.drokin@intel.com>,
"andreas.dilger@intel.com" <andreas.dilger@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"jinshan.xiong@intel.com" <jinshan.xiong@intel.com>,
"aybuke.147@gmail.com" <aybuke.147@gmail.com>,
"john.hammond@intel.com" <john.hammond@intel.com>,
"Julia.Lawall@lip6.fr" <Julia.Lawall@lip6.fr>
Cc: "HPDD-discuss@lists.01.org" <HPDD-discuss@ml01.01.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] staging: lustre: replace kzalloc with copy_from_user with memdup_user
Date: Tue, 31 Mar 2015 15:10:33 +0000 [thread overview]
Message-ID: <20150331150933.GA2833@chaitanya-Ideapad-Z560> (raw)
This patch replaces kzalloc and copy_from_user with memdup_user call
This change was detected with coccinelle tool
Signed-off-by: Chaitanya Dhere <cvijaydh@visteon.com>
---
drivers/staging/lustre/lustre/llite/file.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
index 85e74d1..85b5567 100644
--- a/drivers/staging/lustre/lustre/llite/file.c
+++ b/drivers/staging/lustre/lustre/llite/file.c
@@ -2368,14 +2368,9 @@ ll_file_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
struct hsm_state_set *hss;
int rc;
- hss = kzalloc(sizeof(*hss), GFP_NOFS);
- if (!hss)
- return -ENOMEM;
-
- if (copy_from_user(hss, (char *)arg, sizeof(*hss))) {
- OBD_FREE_PTR(hss);
- return -EFAULT;
- }
+ hss = memdup_user((char *)arg, sizeof(*hss));
+ if (IS_ERR(hss))
+ return PTR_ERR(hss);
rc = ll_hsm_state_set(inode, hss);
--
1.7.9.5
next reply other threads:[~2015-03-31 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 15:10 Dhere, Chaitanya (C.) [this message]
2015-03-31 15:15 ` Julia Lawall
2015-03-31 15:57 ` gregkh
2015-03-31 22:45 ` Drokin, Oleg
2015-04-02 10:18 ` Julia Lawall
2015-04-03 18:56 ` Drokin, Oleg
2015-04-03 19:51 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331150933.GA2833@chaitanya-Ideapad-Z560 \
--to=cvijaydh@visteon.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=Julia.Lawall@lip6.fr \
--cc=andreas.dilger@intel.com \
--cc=aybuke.147@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinshan.xiong@intel.com \
--cc=john.hammond@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®