From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755303AbbCaPs5 (ORCPT ); Tue, 31 Mar 2015 11:48:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58441 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753154AbbCaPs4 (ORCPT ); Tue, 31 Mar 2015 11:48:56 -0400 Date: Tue, 31 Mar 2015 17:48:44 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: David Ahern , Stephane Eranian , Jiri Olsa , LKML Subject: Re: [BUG] perf script segfault Message-ID: <20150331154844.GA1812@krava.brq.redhat.com> References: <5519D376.6010509@gmail.com> <20150330234533.GA9438@kernel.org> <20150331125920.GE9438@kernel.org> <20150331135801.GB3777@krava.brq.redhat.com> <20150331140216.GG9438@kernel.org> <20150331141326.GH9438@kernel.org> <20150331142557.GB31798@krava.brq.redhat.com> <20150331143744.GI9438@kernel.org> <20150331145739.GJ9438@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150331145739.GJ9438@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2015 at 11:57:39AM -0300, Arnaldo Carvalho de Melo wrote: SNIP > struct ordered_events *oe = &session->ordered_events; > - struct perf_tool *tool = oe->tool; > + struct perf_tool *tool = session->tool; > int fd = perf_data_file__fd(session->file); > u64 head, page_offset, file_offset, file_pos, size; > int err, mmap_prot, mmap_flags, map_idx = 0; > @@ -1394,6 +1407,7 @@ out: > out_err: > ui_progress__finish(); > perf_tool__warn_about_errors(tool, &session->evlist->stats); > + ordered_events__warn_about_errors(&session->ordered_events); how about just single warning function ? perf_session__warn_about_errors(struct perf_session *session) session has now both tool and ordered_events jirka