From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752570AbbCaXGk (ORCPT ); Tue, 31 Mar 2015 19:06:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54857 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbbCaXGj (ORCPT ); Tue, 31 Mar 2015 19:06:39 -0400 Date: Tue, 31 Mar 2015 16:06:38 -0700 From: Andrew Morton To: Yury Norov Cc: linux@horizon.com, klimov.linux@gmail.com, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] lib: bitmap_[empty,full]: remove code duplication Message-Id: <20150331160638.8f622be3769fb1cc4418f582@linux-foundation.org> In-Reply-To: <1427594635-11759-1-git-send-email-yury.norov@gmail.com> References: <1426528599-3735-1-git-send-email-yury.norov@gmail.com> <1427594635-11759-1-git-send-email-yury.norov@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Mar 2015 05:03:55 +0300 Yury Norov wrote: > Function 'bitmap_empty' has it's own implementation. > But it's clearly as simple as: > "find_first_bit(src, nbits) == nbits" > The same is true for 'bitmap_full'. Looks OK. Please send a Signed-off-by: for this patch.