From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751899AbbCaQ03 (ORCPT ); Tue, 31 Mar 2015 12:26:29 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:54871 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752983AbbCaQ0U (ORCPT ); Tue, 31 Mar 2015 12:26:20 -0400 Date: Tue, 31 Mar 2015 17:25:48 +0100 From: Russell King - ARM Linux To: Yakir Yang Cc: David Airlie , Philipp Zabel , djkurtz@chromium.org, Fabio Estevam , Shawn Guo , Rob Clark , Mark Yao , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andy Yan , mmind00@googlemail.com, dianders@chromium.org, marcheu@chromium.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 0/3] Improve eye-diagram & single-ended test for rk3288 hdmi Message-ID: <20150331162548.GT24899@n2100.arm.linux.org.uk> References: <1425894141-360-1-git-send-email-ykk@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425894141-360-1-git-send-email-ykk@rock-chips.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 05:42:21PM +0800, Yakir Yang wrote: > RK3288 hdmi eye-diagram test would fail when pixel clock is 148.5MHz, > and single-ended test would failed when display mode is 74.25MHz. Has anyone reviewed these changes yet? I don't see any replies, nor are they in David's git tree. To me, they look mostly fine - the only issue I get is that the final patch doesn't apply cleanly to dw_hdmi.h since they're generated against a tree which has audio support merged. I also see no regressions on iMX6, so I think they can be merged. Unless anyone has any objections, I'll add these to my queue for David. Thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.