From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752847AbbCaXiN (ORCPT <rfc822;w@1wt.eu>);
	Tue, 31 Mar 2015 19:38:13 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:55027 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752541AbbCaXiK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 31 Mar 2015 19:38:10 -0400
Date: Tue, 31 Mar 2015 16:38:08 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Philipp Hachtmann <phacht@linux.vnet.ibm.com>,
        Fabian Frederick <fabf@skynet.be>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Emil Medve <Emilian.Medve@freescale.com>,
        Akinobu Mita <akinobu.mita@gmail.com>,
        Tang Chen <tangchen@cn.fujitsu.com>, Tony Luck <tony.luck@intel.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memblock: add debug output for the memblock_add
Message-Id: <20150331163808.6ffa50f3140b50828bd5dba8@linux-foundation.org>
In-Reply-To: <1427562483-29839-1-git-send-email-kuleshovmail@gmail.com>
References: <1427562483-29839-1-git-send-email-kuleshovmail@gmail.com>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 28 Mar 2015 23:08:03 +0600 Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

> memblock_reserve function calls memblock_reserve_region which
> prints debugging information if 'memblock=debug' passed to the
> command line. This patch adds the same behaviour, but for the 
> memblock_add function.
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
>  mm/memblock.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 252b77b..c7b8306 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -580,10 +580,24 @@ int __init_memblock memblock_add_node(phys_addr_t base, phys_addr_t size,
>  	return memblock_add_range(&memblock.memory, base, size, nid, 0);
>  }
>  
> +static int __init_memblock memblock_add_region(phys_addr_t base,
> +						phys_addr_t size,
> +						int nid,
> +						unsigned long flags)
> +{
> +	struct memblock_type *_rgn = &memblock.memory;
> +
> +	memblock_dbg("memblock_memory: [%#016llx-%#016llx] flags %#02lx %pF\n",

I guess this should be "memblock_add:".  That's what
memblock_reserve_region() does?

--- a/mm/memblock.c~mm-memblock-add-debug-output-for-the-memblock_add-fix
+++ a/mm/memblock.c
@@ -587,7 +587,7 @@ static int __init_memblock memblock_add_
 {
 	struct memblock_type *_rgn = &memblock.memory;
 
-	memblock_dbg("memblock_memory: [%#016llx-%#016llx] flags %#02lx %pF\n",
+	memblock_dbg("memblock_add: [%#016llx-%#016llx] flags %#02lx %pF\n",
 		     (unsigned long long)base,
 		     (unsigned long long)base + size - 1,
 		     flags, (void *)_RET_IP_);
_