From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] rtc: hctosys: use function name in the error log
Date: Wed, 1 Apr 2015 05:01:24 +0200 [thread overview]
Message-ID: <20150401030124.GO3849@piout.net> (raw)
In-Reply-To: <1427576976-22353-3-git-send-email-aaro.koskinen@iki.fi>
On 28/03/2015 at 23:09:36 +0200, Aaro Koskinen wrote :
> Use function name in the error log instead of __FILE__.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/rtc/hctosys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/hctosys.c b/drivers/rtc/hctosys.c
> index 6c719f2..7748a61 100644
> --- a/drivers/rtc/hctosys.c
> +++ b/drivers/rtc/hctosys.c
> @@ -33,7 +33,7 @@ static int __init rtc_hctosys(void)
>
> if (rtc == NULL) {
> pr_err("%s: unable to open rtc device (%s)\n",
> - __FILE__, CONFIG_RTC_HCTOSYS_DEVICE);
> + __func__, CONFIG_RTC_HCTOSYS_DEVICE);
> goto err_open;
> }
>
> --
> 2.2.0
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-04-01 3:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 21:09 [PATCH 1/3] rtc: initialize rtc name early Aaro Koskinen
2015-03-28 21:09 ` [PATCH 2/3] rtc: __rtc_read_time: reduce log level Aaro Koskinen
2015-04-01 3:21 ` Alexandre Belloni
2015-04-01 3:25 ` Joe Perches
2015-04-01 9:55 ` Alexandre Belloni
2015-03-28 21:09 ` [PATCH 3/3] rtc: hctosys: use function name in the error log Aaro Koskinen
2015-04-01 3:01 ` Alexandre Belloni [this message]
2015-04-01 3:18 ` Joe Perches
2015-04-01 7:05 ` [rtc-linux] " Alessandro Zummo
2015-04-01 7:15 ` Joe Perches
2015-04-01 10:42 ` Alexandre Belloni
2015-04-01 16:12 ` [PATCH] rtc: Use more standard kernel logging styles Joe Perches
2015-04-02 7:47 ` [rtc-linux] " Krzysztof Kozlowski
2015-04-05 10:17 ` Alexandre Belloni
2015-04-01 3:01 ` [PATCH 1/3] rtc: initialize rtc name early Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401030124.GO3849@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=aaro.koskinen@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome