From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753462AbbDADvi (ORCPT ); Tue, 31 Mar 2015 23:51:38 -0400 Received: from mga01.intel.com ([192.55.52.88]:51299 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752398AbbDADvZ (ORCPT ); Tue, 31 Mar 2015 23:51:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,503,1422950400"; d="scan'208";a="688648440" Date: Wed, 1 Apr 2015 09:17:02 +0530 From: Vinod Koul To: Petr Kulhavy Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, peter.ujfalusi@ti.com, linux-omap@vger.kernel.org, trivial@kernel.org Subject: Re: [PATCH 2/2] EDMA: TI: fixed wrongly initialized data parameter to the edma callback Message-ID: <20150401034701.GV7192@intel.com> References: <1427142901-16391-1-git-send-email-petr@barix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427142901-16391-1-git-send-email-petr@barix.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2015 at 09:35:01PM +0100, Petr Kulhavy wrote: > The "data" parameter passed indirectly to the edma_callback() should be > edma_chan and not the dma_chan. > > This bug was so far harmless since the offset of struct dma_chan within struct > edma_chan is 0. However as soon as someone changes struct edma_chan this would > cause troubles. Applied now, but do ensure you are using right subsystem anmes for patches. I have fixed up now -- ~Vinod