From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752535AbbDAHk0 (ORCPT ); Wed, 1 Apr 2015 03:40:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58259 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbbDAHkX (ORCPT ); Wed, 1 Apr 2015 03:40:23 -0400 Date: Wed, 1 Apr 2015 09:40:18 +0200 From: Jan Kara To: =?utf-8?B?THVrw6HFoQ==?= Czerner Cc: Wei Yuan , jack@suse.cz, akpm@linux-foundation.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, lizefan@huawei.com Subject: Re: [PATCH] ext3: Remove useless condition in if statement. Message-ID: <20150401074018.GA26339@quack.suse.cz> References: <1426820950-4720-1-git-send-email-weiyuan.wei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 23-03-15 11:30:44, Lukáš Czerner wrote: > On Fri, 20 Mar 2015, Wei Yuan wrote: > > > Date: Fri, 20 Mar 2015 11:09:10 +0800 > > From: Wei Yuan > > To: jack@suse.cz, akpm@linux-foundation.org, adilger.kernel@dilger.ca > > Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, > > lczerner@redhat.com, lizefan@huawei.com > > Subject: [PATCH] ext3: Remove useless condition in if statement. > > > > In this if statement, the previous condition is useless, the later one has covered it. > > Nice that you've send this ext3 counterpart for ext4 patch. Thanks! > > Reviewed-by: Lukas Czerner Thanks. I've added the patch to my tree. Honza > > > > > Signed-off-by: Weiyuan > > --- > > fs/ext3/xattr.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/fs/ext3/xattr.c b/fs/ext3/xattr.c > > index c6874be..24215dc 100644 > > --- a/fs/ext3/xattr.c > > +++ b/fs/ext3/xattr.c > > @@ -546,8 +546,7 @@ ext3_xattr_set_entry(struct ext3_xattr_info *i, struct ext3_xattr_search *s) > > free += EXT3_XATTR_LEN(name_len); > > } > > if (i->value) { > > - if (free < EXT3_XATTR_SIZE(i->value_len) || > > - free < EXT3_XATTR_LEN(name_len) + > > + if (free < EXT3_XATTR_LEN(name_len) + > > EXT3_XATTR_SIZE(i->value_len)) > > return -ENOSPC; > > } > > -- Jan Kara SUSE Labs, CR