From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752910AbbDAJAK (ORCPT ); Wed, 1 Apr 2015 05:00:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34150 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751358AbbDAJAE (ORCPT ); Wed, 1 Apr 2015 05:00:04 -0400 Date: Wed, 1 Apr 2015 10:59:57 +0200 From: Jan Kara To: Lino Sanfilippo Cc: Fabian Frederick , Andrew Morton , Eric Paris , linux-kernel@vger.kernel.org, David Howells , Jan Kara Subject: Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send_event() Message-ID: <20150401085957.GF26339@quack.suse.cz> References: <1426884968-1747-1-git-send-email-fabf@skynet.be> <20150320140943.9cca246285c4fa21b7621872@linux-foundation.org> <550CC2D1.9070305@gmx.de> <550CC625.9090003@gmx.de> <1702390928.185057.1427017594441.open-xchange@webmail.nmp.proximus.be> <550E9DF4.7@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <550E9DF4.7@gmx.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 22-03-15 11:48:20, Lino Sanfilippo wrote: > On 22.03.2015 10:46, Fabian Frederick wrote: > > > Let's hope it only breaks ltp tests and no _real_ userland stuff > > (search systems ...) > > > > Regards, > > Fabian > > > > Hi Fabian, > > yes, that worries me too. I know that there have been discussions on > lkml in which it was made clear that userspace breakage is frowned upon. > And it is obvious, that the latest changes concerning the handling of > FAN_ONDIR are also visible to userspace. But since the concerning > patches have been accepted I think it is ok. I could be wrong though. > > Maybe someone with a deeper knowledge of kernel policy/guidelines could > comment on this? For now I'd stay calm. Events on directories with fanotify are hopelessly useless anyway so I doubt anyone uses them. I just tested those in fanotify LTP testcase for completeness (and screwed that up as you noted). If we find a real application that tries to use directory events with fanotify and which is broken by this patch, we'll have to revert it, that's for sure. Honza -- Jan Kara SUSE Labs, CR