From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753317AbbDALtY (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Apr 2015 07:49:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49946 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751738AbbDALtU (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Apr 2015 07:49:20 -0400
Date: Wed, 1 Apr 2015 13:49:15 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Namhyung Kim <namhyung@gmail.com>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH V7 01/25] perf header: Add AUX area tracing feature
Message-ID: <20150401114915.GA6992@krava.brq.redhat.com>
References: <1427801934-25588-1-git-send-email-adrian.hunter@intel.com>
 <1427801934-25588-2-git-send-email-adrian.hunter@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1427801934-25588-2-git-send-email-adrian.hunter@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 31, 2015 at 02:38:30PM +0300, Adrian Hunter wrote:
> Add a feature to indicate that a perf.data file
> contains AUX area data.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

> ---
>  tools/perf/util/header.c | 14 ++++++++++++++
>  tools/perf/util/header.h |  1 +
>  2 files changed, 15 insertions(+)
> 
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index fb43215..c6739dd 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -869,6 +869,13 @@ static int write_branch_stack(int fd __maybe_unused,
>  	return 0;
>  }
>  
> +static int write_auxtrace(int fd __maybe_unused,
> +			  struct perf_header *h __maybe_unused,
> +			  struct perf_evlist *evlist __maybe_unused)
> +{
> +	return 0;
> +}
> +
>  static void print_hostname(struct perf_header *ph, int fd __maybe_unused,
>  			   FILE *fp)
>  {
> @@ -1163,6 +1170,12 @@ static void print_branch_stack(struct perf_header *ph __maybe_unused,
>  	fprintf(fp, "# contains samples with branch stack\n");
>  }
>  
> +static void print_auxtrace(struct perf_header *ph __maybe_unused,
> +			   int fd __maybe_unused, FILE *fp)
> +{
> +	fprintf(fp, "# contains AUX area data (e.g. instruction trace)\n");
> +}
> +
>  static void print_pmu_mappings(struct perf_header *ph, int fd __maybe_unused,
>  			       FILE *fp)
>  {
> @@ -1873,6 +1886,7 @@ static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
>  	FEAT_OPA(HEADER_BRANCH_STACK,	branch_stack),
>  	FEAT_OPP(HEADER_PMU_MAPPINGS,	pmu_mappings),
>  	FEAT_OPP(HEADER_GROUP_DESC,	group_desc),
> +	FEAT_OPA(HEADER_AUXTRACE,	auxtrace),
>  };
>  
>  struct header_print_data {
> diff --git a/tools/perf/util/header.h b/tools/perf/util/header.h
> index 3bb90ac..d4d5796 100644
> --- a/tools/perf/util/header.h
> +++ b/tools/perf/util/header.h
> @@ -30,6 +30,7 @@ enum {
>  	HEADER_BRANCH_STACK,
>  	HEADER_PMU_MAPPINGS,
>  	HEADER_GROUP_DESC,
> +	HEADER_AUXTRACE,
>  	HEADER_LAST_FEATURE,
>  	HEADER_FEAT_BITS	= 256,
>  };
> -- 
> 1.9.1
>