From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355AbbDAL5i (ORCPT ); Wed, 1 Apr 2015 07:57:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43748 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbbDAL5g (ORCPT ); Wed, 1 Apr 2015 07:57:36 -0400 Date: Wed, 1 Apr 2015 13:57:31 +0200 From: Jiri Olsa To: Adrian Hunter Cc: Peter Zijlstra , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, David Ahern , Frederic Weisbecker , Namhyung Kim , Stephane Eranian Subject: Re: [PATCH V7 00/25] perf tools: Introduce an abstraction for AUX Area and Instruction Tracing Message-ID: <20150401115731.GH6992@krava.brq.redhat.com> References: <1427801934-25588-1-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427801934-25588-1-git-send-email-adrian.hunter@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2015 at 02:38:29PM +0300, Adrian Hunter wrote: SNIP > > Changes in V7: > > Changes requested by Jiri: > > perf evlist: Add initial support for mmapping an AUX area buffer > WARN_ONCE if mm->base is not NULL when mmapping > > perf tools: Add support for AUX area recording > Use perf_can_sample_identifier() consistently > Drop unused function perf_event__synthesize_auxtrace() > > perf record: Add basic AUX area tracing support > Check length before calling record__write a second time > > perf record: Extend -m option for AUX area tracing mmap pages > Update change log with -m option change syntax I sent some acks, I'll continue the review the rest thanks, jirka