From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753529AbbDAM3v (ORCPT ); Wed, 1 Apr 2015 08:29:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50281 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258AbbDAM3s (ORCPT ); Wed, 1 Apr 2015 08:29:48 -0400 Date: Wed, 1 Apr 2015 14:29:43 +0200 From: Jan Kara To: Taesoo Kim Cc: jack@suse.cz, linux-kernel@vger.kernel.org, taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu, csong84@gatech.edu Subject: Re: [PATCH 1/1] udf: update ctime and mtime of new_dir Message-ID: <20150401122943.GJ26339@quack.suse.cz> References: <1427230045-11457-1-git-send-email-tsgatesv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427230045-11457-1-git-send-email-tsgatesv@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 24-03-15 16:47:25, Taesoo Kim wrote: > Upon successful rename(), update ctime and mtime of new_dir > as posix specifies. > > Signed-off-by: Taesoo Kim Thanks for spotting the problem! But you apparently didn't test the patch because it doesn't fix the problem - you've placed the timestamp update into a wrong branch. Please test the patches before you send them. I've fixed the problem together with similar issues during file creation, link, etc. Honza > --- > fs/udf/namei.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/udf/namei.c b/fs/udf/namei.c > index 33b246b..eca1955 100644 > --- a/fs/udf/namei.c > +++ b/fs/udf/namei.c > @@ -1144,6 +1144,8 @@ static int udf_rename(struct inode *old_dir, struct dentry *old_dentry, > inode_dec_link_count(new_inode); > else { > inc_nlink(new_dir); > + new_dir->i_ctime = new_dir->i_mtime > + = current_fs_time(new_dir->i_sb); > mark_inode_dirty(new_dir); > } > } > -- > 2.3.3 > -- Jan Kara SUSE Labs, CR