From: Peter Zijlstra <peterz@infradead.org>
To: Waiman Long <waiman.long@hp.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Shuah Khan <shuahkh@osg.samsung.com>,
Scott J Norton <scott.norton@hp.com>,
Douglas Hatch <doug.hatch@hp.com>
Subject: Re: [PATCH] lfsr: a simple binary Galois linear feedback shift register
Date: Wed, 1 Apr 2015 20:46:25 +0200 [thread overview]
Message-ID: <20150401184625.GA9447@dyad.arnhem.chello.nl> (raw)
In-Reply-To: <20150401164632.GN23123@twins.programming.kicks-ass.net>
On Wed, Apr 01, 2015 at 06:46:32PM +0200, Peter Zijlstra wrote:
> >
> > Since it is used in conjunction with hashing, it is possible that hashing
> > can produce a value of 0. Do we really want to have a warning for that?
> > Alternatively, we can pass in some flag to decide if a warning should be
> > issued.
>
> So if we present it as generic code we cannot assume what it'll be used
> for. The only thing we know is that it should never be 0, so warn for it
> and let the user deal with it.
Also while i like the lfsr probe i feel we should listen to my wiser self and
go with a simpler linear probe first. Only of we find prpblems with that should
we look into different things.
prev parent reply other threads:[~2015-04-01 18:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 17:28 Waiman Long
2015-03-31 19:21 ` Shuah Khan
2015-03-31 21:53 ` Waiman Long
2015-03-31 21:58 ` Shuah Khan
2015-03-31 22:23 ` Waiman Long
2015-04-01 7:45 ` Peter Zijlstra
2015-04-01 14:08 ` Waiman Long
2015-04-01 7:53 ` Peter Zijlstra
2015-04-01 14:15 ` Waiman Long
2015-04-01 16:46 ` Peter Zijlstra
2015-04-01 18:46 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401184625.GA9447@dyad.arnhem.chello.nl \
--to=peterz@infradead.org \
--cc=doug.hatch@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=scott.norton@hp.com \
--cc=shuahkh@osg.samsung.com \
--cc=waiman.long@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®