From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753327AbbDBIhJ (ORCPT ); Thu, 2 Apr 2015 04:37:09 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:34228 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753172AbbDBIhD (ORCPT ); Thu, 2 Apr 2015 04:37:03 -0400 Date: Thu, 2 Apr 2015 10:36:47 +0200 From: Peter Zijlstra To: Ingo Molnar Cc: John Stultz , lkml , Thomas Gleixner , Prarit Bhargava , Richard Cochran Subject: Re: [PATCH 21/21] time: Rework debugging variables so they aren't global Message-ID: <20150402083647.GT23123@twins.programming.kicks-ass.net> References: <1427945681-29972-1-git-send-email-john.stultz@linaro.org> <1427945681-29972-22-git-send-email-john.stultz@linaro.org> <20150402074739.GP23123@twins.programming.kicks-ass.net> <20150402075151.GA24591@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150402075151.GA24591@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2015 at 09:51:51AM +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > On Wed, Apr 01, 2015 at 08:34:41PM -0700, John Stultz wrote: > > > Ingo suggested that the timekeeping debugging variables > > > recently added should not be global, and should be tied > > > to the timekeeper's read_base. > > > > But why? its the same hardware clock for both tkr's. Surely if one goes > > funny the other will too. > > > > It doesn't make sense to duplicate this. > > Well, could it be moved to the timekeeper data structure? What I was > opposed to was making it super-global, after all the (nice) effort we > made to tidy up global data structures in this area. Sure, struct timekeeper would work, the debug code already references the global tk_core to access that.