From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753006AbbDBJOw (ORCPT ); Thu, 2 Apr 2015 05:14:52 -0400 Received: from mga02.intel.com ([134.134.136.20]:59341 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752342AbbDBJOt (ORCPT ); Thu, 2 Apr 2015 05:14:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,509,1422950400"; d="scan'208";a="707831272" Date: Thu, 2 Apr 2015 17:14:45 +0800 From: Fengguang Wu To: Joe Perches Cc: Zach Reizner , kbuild-all@01.org, Dave Airlie , Adam Jackson , Ben Widawsky , David Airlie , Rob Clark , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH drm] drm/vgem: vgem_gem_dumb_map() can be static Message-ID: <20150402091445.GB16334@wfg-t540p.sh.intel.com> References: <201504021036.7YJmcdVc%fengguang.wu@intel.com> <20150402025959.GA15100@snb> <1427943895.18444.4.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427943895.18444.4.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 01, 2015 at 08:04:55PM -0700, Joe Perches wrote: > On Thu, 2015-04-02 at 10:59 +0800, kbuild test robot wrote: > > Signed-off-by: Fengguang Wu > [] > > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c > [] > > @@ -195,7 +195,7 @@ static int vgem_gem_dumb_create(struct drm_file *file, struct drm_device *dev, > > return 0; > > } > > > > -int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, > > +static int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, > > uint32_t handle, uint64_t *offset) > > Hello Fengguang. > > When you or your robot does these, can you please > make sure the entire statement is indented properly? OK, added it to the TODO list. Sorry for the inconvenience! Thanks, Fengguang