From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753347AbbDBNtk (ORCPT ); Thu, 2 Apr 2015 09:49:40 -0400 Received: from smtprelay0018.hostedemail.com ([216.40.44.18]:42936 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751856AbbDBNth (ORCPT ); Thu, 2 Apr 2015 09:49:37 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 40,2.5,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:4250:5007:6119:6261:7875:7903:9163:10011:10400:10848:10967:11026:11232:11473:11658:11914:12296:12517:12519:12740:13069:13161:13229:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:1:0 X-HE-Tag: bait50_53cd98ffd9145 X-Filterd-Recvd-Size: 2434 Date: Thu, 2 Apr 2015 09:49:34 -0400 From: Steven Rostedt To: Mark Brown Cc: "linux-kernel@vger.kernel.org" , Ingo Molnar , Andrew Morton , Namhyung Kim , Masami Hiramatsu , Mathieu Desnoyers Subject: Re: [RFC][PATCH 01/17 v2] tracing: Add TRACE_SYSTEM_VAR to intel-sst Message-ID: <20150402094934.4e041df2@gandalf.local.home> In-Reply-To: <20150402134033.GR6023@sirena.org.uk> References: <20150402015648.249824760@goodmis.org> <20150402020940.190664766@goodmis.org> <20150402093249.525130e7@gandalf.local.home> <20150402093341.0265b1b5@gandalf.local.home> <20150402134033.GR6023@sirena.org.uk> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Apr 2015 14:40:33 +0100 Mark Brown wrote: > On Thu, Apr 02, 2015 at 09:33:41AM -0400, Steven Rostedt wrote: > > Steven Rostedt wrote: > > > > I couldn't find anything in MAINTAINERS about that file, but I didn't > > > look for your name though. > > > BTW, was that considered an Acked-by? > > I guess, you probably want to ping the Intel guys though since it's them > that would be affected by the interface change. Actually, there's no interface change. This is the work-around patch to that. It's only internal to the kernel and userspace does not see any difference. I just needed a unique TRACE_SYSTEM name that was also a valid C variable, and now use TRACE_SYSTEM_VAR. The ftrace code now has: #ifndef TRACE_SYSTEM_VAR #define TRACE_SYSTEM_VAR TRACE_SYSTEM #endif And this allows trace headers (like intel-sst.h) to have a different VAR variable from the TRACE_SYSTEM name: #define TRACE_SYSTEM intel-ssl #define TRACE_SYSTEM_VAR intel_ssl This lets me use something that will work and not need to change what the user space sees. -- Steve