mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: "Masami Hiramatsu" <masami.hiramatsu.pt@hitachi.com>,
	"Namhyung Kim" <namhyung@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Pádraig Brady" <P@draigBrady.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Dave Jones" <davej@codemonkey.org.uk>,
	"Luis Henriques" <luis.henriques@canonical.com>
Subject: Re: [PATCH v2.1] ftracetest: Do not use usleep directly
Date: Thu, 2 Apr 2015 11:08:46 -0400	[thread overview]
Message-ID: <20150402110846.4e6a756c@gandalf.local.home> (raw)
In-Reply-To: <551D5019.9010806@osg.samsung.com>

On Thu, 02 Apr 2015 08:20:09 -0600
Shuah Khan <shuahkh@osg.samsung.com> wrote:


> >>> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> >>> Reported-by: Dave Jones <davej@codemonkey.org.uk>
> >>> Reported-by: Luis Henriques <luis.henriques@canonical.com>
> >>> Based-on-patch-by: Pádraig Brady <P@draigBrady.com>
> 
> Is this standard? checkpatch complained as non-standard. I am
> seeing some patches posted with Based-on-patch-by

I ignore checkpatch for things like this. It doesn't have a foggiest
clue to what is standard. The only standard we truly have that counts
is "Signed-off-by", as that's partially a legal thing. Everything else
is info only.

This patch was based on a idea by Pádraig Brady and Namhyung is giving
him credit.

Hmm, since I do not believe that Pádraig sent a patch, but only
suggested the idea, the more "standard" tag, and actually more
appropriate tag would be:

Suggested-by: Pádraig Brady <P@draigBrady.com>

Also, we probably should add:

Link: http://lkml.kernel.org/r/1427329943-16896-1-git-send-email-namhyung@kernel.org

Which has more of a history for this patch.

> 
> Anyway, I have this patch tagged for 4.1-rc2

Why rc2?

-- Steve


  reply	other threads:[~2015-04-02 15:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02  4:24 [PATCH v2] " Namhyung Kim
2015-04-02  4:34 ` [PATCH v2.1] " Namhyung Kim
2015-04-02  5:58   ` Masami Hiramatsu
2015-04-02 13:38     ` Steven Rostedt
2015-04-02 14:20       ` Shuah Khan
2015-04-02 15:08         ` Steven Rostedt [this message]
2015-04-02 16:30           ` Shuah Khan
2015-04-02 16:48             ` Steven Rostedt
2015-04-02 16:52               ` Shuah Khan
2015-04-02 17:26                 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150402110846.4e6a756c@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=P@draigBrady.com \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luis.henriques@canonical.com \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mpe@ellerman.id.au \
    --cc=namhyung@kernel.org \
    --cc=shuahkh@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®