From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753300AbbDBM6e (ORCPT ); Thu, 2 Apr 2015 08:58:34 -0400 Received: from casper.infradead.org ([85.118.1.10]:36063 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752666AbbDBM6b (ORCPT ); Thu, 2 Apr 2015 08:58:31 -0400 Date: Thu, 2 Apr 2015 14:58:19 +0200 From: Peter Zijlstra To: Ingo Molnar Cc: Preeti U Murthy , mpe@ellerman.id.au, tglx@linutronix.de, rjw@rjwysocki.net, nicolas.pitre@linaro.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] clockevents: Fix cpu down race for hrtimer based broadcasting Message-ID: <20150402125819.GX23123@twins.programming.kicks-ass.net> References: <20150330092410.24979.59887.stgit@preeti.in.ibm.com> <20150402104226.GB21105@gmail.com> <20150402120256.GV23123@twins.programming.kicks-ass.net> <20150402121247.GA18104@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150402121247.GA18104@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2015 at 02:12:47PM +0200, Ingo Molnar wrote: > Okay. I'll resurrect the fix with a hotplug_cpu__tick_pull() name - > agreed? Sure. > > > Also, I improved the changelog (attached below), but decided > > > against applying it until these questions are cleared - please use > > > that for future versions of this patch. > > > > > > > Fixes: http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html > > > > You forgot to fix the Fixes line ;-) > > > > My copy has: > > > > Fixes: 5d1638acb9f6 ("tick: Introduce hrtimer based broadcast") > > Hm, not sure how that got lost - my git-log of the patch ported on top > of timers/core still has it: > Suggested-by: Thomas Gleixner > Tested-by: Nicolas Pitre > Signed-off-by: Preeti U. Murthy > Cc: linuxppc-dev@lists.ozlabs.org > Cc: mpe@ellerman.id.au > Cc: nicolas.pitre@linaro.org > Cc: peterz@infradead.org > Cc: rjw@rjwysocki.net > Fixes: http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html > Link: http://lkml.kernel.org/r/20150330092410.24979.59887.stgit@preeti.in.ibm.com > [ Merged it to the latest timer tree, tidied up the changelog. ] > Signed-off-by: Ingo Molnar That doesn't have my Sob in it, so you took it from the list yourself, not from my queue. I also (concurrently it seems) fixed up the Changelog some :-)