From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752983AbbDBReL (ORCPT ); Thu, 2 Apr 2015 13:34:11 -0400 Received: from mail-qc0-f170.google.com ([209.85.216.170]:36502 "EHLO mail-qc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521AbbDBReI (ORCPT ); Thu, 2 Apr 2015 13:34:08 -0400 Date: Thu, 2 Apr 2015 13:34:04 -0400 From: Tejun Heo To: Peter Zijlstra Cc: Sasha Levin , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Andrew Morton , maninder1.s@samsung.com, tglx@linutronix.de, Yogesh Narayan Gaur , AJEET YADAV Subject: Re: restart_syscall: use freezable blocking call Message-ID: <20150402173404.GV9974@htj.duckdns.org> References: <380509604.92081427713655432.JavaMail.weblogic@epmlwas01c> <20150330154351.2582ba70df824c6ccc55fb28@linux-foundation.org> <1982905.Ac4fTCSUaY@vostro.rjw.lan> <20150331150730.GJ23123@twins.programming.kicks-ass.net> <551D683C.2050601@oracle.com> <20150402172513.GE23123@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150402172513.GE23123@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2015 at 07:25:13PM +0200, Peter Zijlstra wrote: > On Thu, Apr 02, 2015 at 12:03:08PM -0400, Sasha Levin wrote: > > It's not correct. > > Yay for lockdep ;-) > > > [ 0.645644] debug_check_no_locks_held (kernel/locking/lockdep.c:4178) > > Should we also have that call in freezer_do_not_count() ? I think conerting a general scheduling function like schedule_hrtimeout to do freezable sleeps blindly is a pretty bad idea. This must be determined per specific sleep site. Thanks. -- tejun