From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752903AbbDCN0W (ORCPT ); Fri, 3 Apr 2015 09:26:22 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.232]:41029 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752384AbbDCN0U (ORCPT ); Fri, 3 Apr 2015 09:26:20 -0400 Date: Fri, 3 Apr 2015 09:26:13 -0400 From: Steven Rostedt To: Miroslav Benes Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org, x86@kernel.org, jkosina@suse.cz Subject: Re: [PATCH RFC tip/perf/core] ftrace/x86: Let dynamic trampolines call ops->func even for dynamic fops Message-ID: <20150403092613.092da54e@grimm.local.home> In-Reply-To: References: <1424357774-13536-1-git-send-email-mbenes@suse.cz> <20150305112256.2a1ca17e@gandalf.local.home> <20150402161242.06bbcfdf@gandalf.local.home> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 Apr 2015 11:29:04 +0200 (CEST) Miroslav Benes wrote: > Yes, this works but there is a slight difference to the previous behaviour > which I tried to preserve in my patch. ftrace_ops_get_func in your patch > does not check FTRACE_FORCE_LIST_FUNC. I do not know if that is a real > problem. Anyway your approach looks much better and dynamic trampolines > are now used for live patches. So in this context you can add Hmm, I'll have to take a deeper look at that. Thanks for noticing. But that will have to wait till Monday, as I have off today ;-) > > Tested-by: Miroslav Benes > Thanks for testing. -- Steve