Re: [PATCH 1/1] irqchip/gicv3-its: remove GITS_BASER_TYPE_CPU base on latest specification

[Jason Cooper <jason@lakedaemon.net>]

Zhen Lei,

On Fri, Apr 03, 2015 at 11:33:52AM +0800, Zhen Lei wrote:
> Acutally, "Interrupt Collections" and "Physical Processors" is the
> same thing.

I'm sorry, but this isn't clear.

> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  drivers/irqchip/irq-gic-v3-its.c   | 2 +-
>  include/linux/irqchip/arm-gic-v3.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 9687f8a..a795aae 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -777,7 +777,7 @@ static int __init its_alloc_lpi_tables(void)
>  static const char *its_base_type_string[] = {
>  	[GITS_BASER_TYPE_DEVICE]	= "Devices",
>  	[GITS_BASER_TYPE_VCPU]		= "Virtual CPUs",
> -	[GITS_BASER_TYPE_CPU]		= "Physical CPUs",
> +	[GITS_BASER_TYPE_RESERVED3]	= "Reserved (3)",

Are you fixing a bug?  Was the old information wrong?  Did the spec get
revised?

Please redo your commit message to explain why this change is necessary and
what it's doing.

>  	[GITS_BASER_TYPE_COLLECTION]	= "Interrupt Collections",
>  	[GITS_BASER_TYPE_RESERVED5] 	= "Reserved (5)",
>  	[GITS_BASER_TYPE_RESERVED6] 	= "Reserved (6)",
> diff --git a/include/linux/irqchip/arm-gic-v3.h b/include/linux/irqchip/arm-gic-v3.h
> index ffbc034..67f5779 100644
> --- a/include/linux/irqchip/arm-gic-v3.h
> +++ b/include/linux/irqchip/arm-gic-v3.h
> @@ -233,7 +233,7 @@
>  #define GITS_BASER_TYPE_NONE		0
>  #define GITS_BASER_TYPE_DEVICE		1
>  #define GITS_BASER_TYPE_VCPU		2
> -#define GITS_BASER_TYPE_CPU		3
> +#define GITS_BASER_TYPE_RESERVED3	3
>  #define GITS_BASER_TYPE_COLLECTION	4
>  #define GITS_BASER_TYPE_RESERVED5	5
>  #define GITS_BASER_TYPE_RESERVED6	6
> --
> 1.8.0

thx,

Jason.