From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753011AbbDCWKF (ORCPT ); Fri, 3 Apr 2015 18:10:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49187 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbbDCWKB (ORCPT ); Fri, 3 Apr 2015 18:10:01 -0400 Date: Fri, 3 Apr 2015 15:10:00 -0700 From: Andrew Morton To: Konstantin Khlebnikov Cc: linux-mm@kvack.org, Sasha Levin , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memory: print also a_ops->readpage in print_bad_pte Message-Id: <20150403151000.b51caa3f692358610fc1ca5d@linux-foundation.org> In-Reply-To: <20150403171818.22742.92919.stgit@buzz> References: <20150403171818.22742.92919.stgit@buzz> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 03 Apr 2015 20:18:18 +0300 Konstantin Khlebnikov wrote: > A lot of filesystems use generic_file_mmap() and filemap_fault(), > f_op->mmap and vm_ops->fault aren't enough to identify filesystem. > > This prints file name, vm_ops->fault, f_op->mmap and a_ops->readpage > (which is almost always implemented and filesystem-specific). > > Example: > > [ 23.676410] BUG: Bad page map in process sh pte:1b7e6025 pmd:19bbd067 > [ 23.676887] page:ffffea00006df980 count:4 mapcount:1 mapping:ffff8800196426c0 index:0x97 > [ 23.677481] flags: 0x10000000000000c(referenced|uptodate) > [ 23.677896] page dumped because: bad pte > [ 23.678205] addr:00007f52fcb17000 vm_flags:00000075 anon_vma: (null) mapping:ffff8800196426c0 index:97 > [ 23.678922] file:libc-2.19.so fault:filemap_fault mmap:generic_file_readonly_mmap readpage:v9fs_vfs_readpage Is that why we print these out? Just to identify the fs type? There's always vma->vm_file->f_inode->i_sb->s_magic ;)